Improve proto generation #5312
Improve proto generation #5312
Conversation
r2k1
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy and
timmy-wright
as code owners
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
aks-node-controller/pkg/gen/aksnodeconfig/v1/tls_bootstrapping_config.pb.go
Outdated
Show resolved
Hide resolved
aks-node-controller/README.md
Outdated
| note over VM: cloud-init handles<br/>config.json deployment | ||
|
|
||
| note over VM: cloud-init completes processing | ||
| note over VM: Start aks-node-controller.service (systemd service)<br/> afer cloud-init |
There was a problem hiding this comment.
nit: typo after.
Thanks for reworking the diagram, much easier to follow.
aks-node-controller/README.md
Outdated
| @@ -4,7 +4,7 @@ This directory contains files related to AKS Node Controller go binary. | |||
|
|
|||
| ## Overview | |||
|
|
|||
| AKS Node Controller is a go binary that is responsible for bootstrapping AKS nodes. The controller expects a predefined contract from the client of type [`AKSNodeConfig`](https://github.com/Azure/AgentBaker/tree/dev/pkg/proto/aksnodeconfig/v1) containing the bootstrap configuration. The controller has two primary functions: 1. Parse the bootstrap config and kickstart bootstrapping and 2. Monitor the completion status. | |||
| AKS Node Controller is a go binary that is responsible for bootstrapping AKS nodes. The controller expects a predefined contract from the client of type [`AKSNodeConfig`](https://github.com/Azure/AgentBaker/tree/dev/pkg/proto/aksnodeconfig/v1) containing the bootstrap configuration. The controller has two primary functions: 1. Parse the bootstrap config and kickstart bootstrapping and 2. Monitor the completion status. | |||
There was a problem hiding this comment.
Can you update the paragraph below to remove the reference to GetNodeBootstrapping now that it is outdated?
| # Emulate running "buf" in the current directory | ||
| BUF = docker run --volume "$(CURDIR)/../:$(CURDIR)/../" --workdir $(CURDIR) bufbuild/buf:1.47.2 | ||
|
|
||
| .PHONY: proto-generate |
There was a problem hiding this comment.
Do we need to manually run make proto-generate before pushing the commit?
There was a problem hiding this comment.
yes, CI may complain about it. But I didn't test it.
| .PHONY: proto-lint | ||
| proto-lint: | ||
| @($(BUF) lint) | ||
| @($(BUF) breaking --against '../.git#branch=dev,subdir=aks-node-controller') # TODO: change to master |
There was a problem hiding this comment.
lint: Not sure if there is a good way to point to default so that we don't need to switch between master and dev every year.
There was a problem hiding this comment.
couldn't find anything in the buf docs, I don't think it's supported. But CI behaves differently, it checks target branch for PRs.
|
|
||
| CSE script: `/opt/azure/containers/aks-node-controller provision-wait` | ||
|
|
||
|
|
||
| #### Provisioning flow diagram: | ||
|
|
||
|  | ||
| ```mermaid | ||
| sequenceDiagram |
There was a problem hiding this comment.
Great we can 'write' a diagram!
/kind cleanup
Note: I didn't test it on amd64. May need to adjust dockerfile if I put an incorrect value there.